raynebc

Yeah, I saw that. I put it on my to-do list to look into.

I got a DM from somebody on the Discord and gave the green light with the disclaimer that if I have reason to dislike a pull request I might refuse to add it to the official code base. Thanks for helping me iron out that last Notes panel bug. The strange thing about it is that since it involved freeing memory, re-allocating the same amount of memory soon after and then using the freed memory instead of the newly-allocated memory, the crash would only happen depending on whether the Operating System randomized memory allocations. My Windows 7 installation doesn't seem to, but I imagine newer versions of Windows do.

For the last several years I have been.

Porting to Allegro 5 (better support for modern hardware/OS) will be a lot of work. The original EOF developer was planning on this quite a while ago, but he seems to be pretty busy in real life and I haven't seen much from him lately. @@firekorn Having you test with the logging has paid off and I think I fixed the bug. Here's another beta if you have time to test it: http://ignition.customsforge.com/eof/download/227

It might be that having that duplicate note written to XML as @@iminashi mentioned has no terrible side effect, but it would be better for EOF not to write a duplicate at all.

Here's another beta with more notes panel logging: http://ignition.customsforge.com/eof/download/225

Let me know if it doesn't work with the newer toolkit, and possibly taking the unneeded split status off. I might have to see if processing a split status for a chord that is automatically being split up during export is a special case I should program for.

I think I sorted out the incomplete logging issue. Here's another beta with more logging focused on the Notes Panel: http://ignition.customsforge.com/eof/download/224

Is the problem only happening while the Note Counts panel is in use? Here's another beta with some adjusted logging: http://ignition.customsforge.com/eof/download/221

I think I found the bug, it's associated with two macros used in the Note Counts panel. Here's a new beta if you could check to make sure you can cause the crash to occur: http://ignition.customsforge.com/eof/download/220 I also toned down the "exhaustive" logging level so even still the logging won't be as ridiculous.

Here's the only other hotfix that was released between the builds you've tested: http://ignition.customsforge.com/eof/download/209 No logging needed for this one, but let me know if it crashes this way. The log file you uploaded seems like it is incomplete (the beginning is missing). At the end, it shows you loaded a file, but it didn't shows you had opened the preferences dialog. Did you have to do anything other than load that project before the crash occurred? Does the crash only occur when the Notes panel is active?

Here's a beta from 1.5 weeks later, if you can try to get it to crash the same way (no log needed for this one): http://ignition.customsforge.com/eof/download/211 Here's another beta with more logging, if you could reproduce the crash and upload the log: http://ignition.customsforge.com/eof/download/219

This one has a little more logging, if you can try to reproduce the crash: http://ignition.customsforge.com/eof/download/218 And here's a beta that was about half-way between the two hotfix releases, if you could test to see if the crash occurs (no logging needed for this test): http://ignition.customsforge.com/eof/download/208

I opened the 5-8-2018 hotfix with your config, opened that project and open and closed preferences, but I couldn't cause a crash. Please try with this beta, which has more logging and should give better information about where the crash occurs: http://ignition.customsforge.com/eof/download/217

I couldn't get EOF to crash using your config file and opening and closing Preferences before or after loading a chart. Are you able to re-configure your preferences back to what you were using, does it cause the crash to resume happening? Can you provide the eof_log.txt file after opening EOF and reproducing the crash?

I can't reproduce either of those crashes. Does it happen on every chart you open or just a specific one? Do you have to change any preference settings for the crash to occur? Does the problem happen if you close EOF, temporarily rename your preferences (eof.cfg) and open EOF (it will recreate the file with all default settings)?

If you still have the Go PlayAlong XML file EOF won't import, please send it to me for testing. If it's like the previous one where it imports, but the beat timestamps aren't what you were expecting, it might still be that EOF imported it as written and there are sync problems in the Go PlayAlong project.

@@dantrag28 Did you have a chance to look into this some more?

Hi, folks. The latest hotfix (5-8-2018) is in the first post. Changes are as follows: *Changed the Information panel to be defined with Notes panel macros as an info.panel.txt file in EOF's program folder. It is now user-editable (just as with the Notes panel, alter in a text editor, save in Windows CRLF line ending format) and is displayed nearly identically to the original Information panel. Hide the Information panel (either press CTRL+I or check box in File>Preferences>Preferences) and unhide it (or re-open EOF) to reload any changes made to the text file. *Added a "Disable automatic backups" preference that will prevent creation of .eof.bak files (created during undo and save operations) and .backup files (created during MIDI/GH/Feedback import). Creation of .ogg.backup files created by adding leading silence is not prevented because it is required in order to be able to undo that operation. *Improved the "Estimate BPM" function to offer to estimate the tempo of just the part of the chart audio between the start and end markers if those markers are defined. If the start marker is at a beat position, the function will offer to apply the estimated tempo to that beat instead of the first beat. *Improved the "Set display width" function to display the current width. *Added a "New notes are force strum" preference that will automatically apply forced HOPO off status for new notes, for Clone Hero authoring. *Added a "File>Display>Notes panel" menu which allows the Notes panel to display one of the built-in panels or a user-specified one. The panel files that are included with EOF will all use the recommended .panel.txt extension, which the Notes panel browse function will filter by. The default notes.txt file was renamed notes.panel.txt accordingly and it lists instructions for selecting/customizing panels. The built-in panels are stored in eof.dat and are recovered from it if the file is missing, so they can can be customized without worry that they could be corrupted (ie. just delete/rename it and re-open the panel in order for it to be reset to default content). The note shortcuts were moved to a note_controls.panel.txt file and will now hide controls that aren't relevant to the active track. The CTRL+P shortcut has been remapped to "File>Display>Notes panel>Enable" since old paste is rarely needed. The P edit menu hotkey was moved to old paste to make it easily usable with 3 keystrokes. *Improved the conditional select/deselect functions to have cymbal checkboxes if the drum track is active, allowing better flexibility to apply to notes that have both a tom and a cymbal, or have either a tom or cymbal on a particular lane. *Added a "File>Export audio range" function that behaves similarly to "Export time range" but just exports the specified amount of audio instead of creating a separate project. "File>Export time range" was renamed to "Export chart range" to differentiate it from this new function. *Improved the export chart range function by having it delete the temporary WAV file used to create the OGG file. *Added a "Beat>Anchor measures" function that alters beats that have a time signature in effect by anchoring the first beat in each measure to its current position and deleting the anchors from the other beats. If the note auto-adjust preference is enabled, the notes are adjusted accordingly to keep their positions within their respective beats. "Beat>Copy Events" and "Beat>Paste Events" were moved into Beat>Events to make room in the Beats menu. *Improved the "Beat>Delete anchor" function to respect the note auto-adjust preference. *Changed the default difficulty naming to Guitar Hero/Rock Band scheme (Easy, Medium, Hard, Expert). The new "Use FoF difficulty naming" preference can be enabled if you want to change back to EOF's original difficulty naming. *Improved the piano roll to display the letter h below a 5 or 6 button guitar/bass note if it is a forced HOPO, or to display (h) beneath the guitar/bass note if it is determined to be a automatic HOPO based on the current "Edit>Preview HOPO" setting. *Resolved anchor creation errors that could occur if the secondary piano roll is active during Rocksmith export. *Changed the lane order of GHL mode so that it matches Moonscraper (1=B1,2=B2,3=B3,4=W1,5=W2,6=W3). *Created a "Note>GHL" menu, moved "Convert GHL open" (which has been assigned the CTRL+G shortcut when a GHL track is active) to it and added a new "Swap B/W gems" function that will swap the black/white coloring for all selected GHL notes (ie. a B1W2 chord will become a W1B2 chord). *Corrected the editor logic that toggles open strum notes for existing notes. *Added a large number of Notes panel macros, each of which are defined in the macros.htm documentation file and most of which are exemplified in the built-in Notes panels. *Fixed a bug where cloning a six lane legacy guitar track to the keys track would properly retain the correct lane count of 5 and wouldn't apply crazy status as is required for keys notes. *Added a note_counts Notes panel that displays the number of single gem notes, 2 note chords, 3 note chords, 4 note chords, 5 note chords, 6 note chords and open notes along with a list of every possible note and chord (every gem combination) and the number of instances of each in the active track difficulty. If a 4, 5 or 6 gem chord is present in a non pro guitar track, that count is drawn with a red background to warn the author that using such chords is considered a bad charting practice. If a 3 gem chord is present in an easy or medium difficulty, that count is drawn with a red background to warn the author that it's not recommended to use such hard chords in these lower difficulties. For the vocal track, display information about how much of each type of lyric is present, and the number of lyrics there are of each supported pitch from C2 through C6. If a drum chord would require more than two hands to play, a warning is displayed about invalid chords. There isn't enough space to display all chord combinations for GHL and pro guitar modes unless window height is set to 600 or 768 in File>Display>Display. This new panel was added to eof.dat and added to the "File>Display>Notes panel" menu. Open each of the built-in panels once to have them added to EOF's program folder, after which you can examine/edit them. A big change with this hotfix is the GHL mode lane ordering matches that of Moonscraper now. Make sure to disable the "GHL conversion swaps B/W gems" preference if you want non GHL lane 1 (ie. green) to correspond to GHL lane 1 (B1) when copy/pasting between GHL and non GHL tracks, or when converting to/from GHL format. Edit: Let me know what kind of information you guys would want to be in a Rocksmith Notes panel, stuff like the active track's arrangement type, number of difficulties/sections/etc, whether FHPs have been manually defined, other points of CDLC readiness, and so on.

No, in native Windows. I have no Mac testing capability, the Mac VM I have just barely works well enough to build EOF from command line and get the application bundle.

Running EOF in debug mode in Code::Blocks works OK for the most part except that file browser dialogs have some serious delays.

Maybe. I can't support if if it doesn't work or if it runs badly though.

EOF might eventually be updated to Allegro 5, but I probably don't have the time/expertise to do it by myself.

Mac users haven't confirmed for me exactly which version of Mac broke compatibility with EOF, but it seems like High Sierra in general is probably likely.

I'll add that to the to-do list. It shouldn't be hard to add.