Jump to content

Welcome to CustomsForge Forums
Register now to gain access to all of our features. Once registered and logged in, you will be able to create topics, post replies to existing threads, give reputation to your fellow members, get your own private messenger, post status updates, manage your profile and so much more. This message will be removed once you have signed in.
Login to Account Create an Account

Learn & Play Rocksmith!

Want to play the songs you love? Registration and the use of this website is 100% free.
The only thing you need is a legal copy of Rocksmith 2014 w/ a cable. Click here to buy it.
 
Having trouble logging in or registering? Please click "Support" below.



Chlipouni

Chlipouni

Member Since 17 Feb 2014
OFFLINE Last Active Today, 08:00 AM
****-

#248152 Visual glitch in chords self-made CDLC

Posted by Chlipouni on 03 March 2017 - 05:54 PM

@djsoundnr1,

 
  These display glitches are related to open notes inside chords.
   Each open note must have a "chordNote" tag inside the "chord" tag in the XML file (even if the open notes are defined inside the "chordTemplate") ...



#232944 Remastered messed up scoring?

Posted by Chlipouni on 12 October 2016 - 03:52 PM

Distillers For Tonight You're Only Here to Know

 

Here is one that is affected by this issue.

 

 

For your information, none of my customs has this issue, so it is not related to DDC.
 
Since recent releases of tools (EOF & DDC) we allow the manual management of the density status on each chord.
In this case, all chords are forced to low density, so they appear as a full box with all notes inside at each occurrence.
 
For a while, DDC was able to correct this automatically (previous releases). But now, in order to allow the more sophisticated usages of EOF, DDC keeps all statuses as defined in the CDLC.
 
So, to correct this CDLC, ask the creator to remove all "high Density" status on all of its chords. EOF should generate the new statuses automatically.



#232642 Remastered messed up scoring?

Posted by Chlipouni on 10 October 2016 - 01:12 PM

Hi guys !

 

  I have found another error in the RSToolkit code that explains the lack of accuracy in order to obtain a 100% mastery.

 

  New patch just submitted on GitHub.

 

  It will be more difficult to obtain a 100% mastery (needs a 100% accuracy in the higher level of DD).

 

  For those who wants to try a CDLC in these new conditions : Kreva - Kijun (from Billkwando)

 

Enjoy ...




#232553 Remastered messed up scoring?

Posted by Chlipouni on 10 October 2016 - 01:16 AM

I've tried twice to fix an existing custom with the new toolkit and both have still been 100%. :\

 

I changed the DLC key and chose Yes on the option to reset the score. What else am I missing?

 

@Billkwando,

 

  I tried your custom by setting first all DD levels to 0 and here are my scores for each try :

  - 1 : 24% mastery

  - 2 : 55% mastery

  - 3 : 63% mastery

  - 4 : 89% mastery

  - 5 : 90% mastery

  - 6 : 92% mastery

  - 7 : 100% mastery (but with 95% accuracy)

 

  So the fix works, otherwise I would obtained a 100% mastery at the second or the third try (because the lead contains a majority of chords)

  

  We just still need to improve the accuracy of the counter of notes to be more precise when all DD levels are close to 100%

 

  Thanks for this CDLC, a nice discovery for me  :D

  Did you try with the custom which had the same issue with the previous release of RS2014 ?




#232435 Remastered messed up scoring?

Posted by Chlipouni on 09 October 2016 - 11:35 AM

@dreddfoxx

 

I tried the psarc you sent. Regenerated it and played it (lead). Got 98% accuracy and 100% mastery.  :unsure:

 

Also, with my the test custom, which consists of 20 chords, the mastery seems to work otherwise except when I hit just one chord, then the mastery will be 0% with 5% accuracy.

 

EDIT: Tried one of my own actual customs. Seemed to work without DD. With DDC, 96% accuracy, 100% mastery. 

 

 The current fix avoids obtaining 100% mastery with only 45% accuracy.

 Now, the way how the Toolkit counts the single notes and chords might be refined in a near future in order to improve its accuracy.




#232384 Remastered messed up scoring?

Posted by Chlipouni on 09 October 2016 - 07:22 AM

@Chlipouni, feel free to submit pull request, I'll approve it, since I don't have my pc with me now I'm unable to do it myself  :wacko:

 

 

Pull request submitted on GitHub ...




#232345 Remastered messed up scoring?

Posted by Chlipouni on 09 October 2016 - 04:29 AM

@cozy1,

 

  I downloaded the last release of the Toolkit (source code) and made the following change by myself.

 

  File : Sng2014FileWriter.cs

  Line : 1025

old line : if (chord.Time >= piter.Time && piter.Time >= chord.Time)
new line : if (piter.Time > chord.Time)

 Then I built the RSToolkit, ran it and generated my CDLC ...

 

 ==> NO MORE ISSUE ABOUT 100% Scoring Bug

 ==> PROBLEM IS SOLVED

 

 @cozy1, you can put back the "Techniques" section in the JSON file, it was not the cause of this issue.




#232296 Remastered messed up scoring?

Posted by Chlipouni on 08 October 2016 - 06:42 PM

@cozy1,

 

  I looked deeper in the code by comparing v2.3.0.0 vs v2.4.1.0 and I found this difference that could explain the 100% scoring issue :

 

File : \RocksmithToolkitLib\Sng\Sng2014FileWriter.cs

Function : parseArrangements

 

In v2.4.1.0 we have this :

                    for (int j=0; j<xml.PhraseIterations.Length; j++) {
                        var piter = xml.PhraseIterations[j];
                        if (chord.Time >= piter.Time && piter.Time >= chord.Time)               -- In my opinion this condition is equivalent to : "chord.Time = piter.Time" !
                        {
                            if (chord.Ignore == 0)
                                ++a.NotesInIteration1[j];
                            ++a.NotesInIteration2[j]; // j-1 not safe with j=0
                            break;
                        }
                    } 

In v2.3.0.0 we have this :

                    for (int j=0; j<xml.PhraseIterations.Length; j++) {
                        var piter = xml.PhraseIterations[j];
                        if (piter.Time > chord.Time) {
                            if (chord.Ignore == 0)
                                ++a.NotesInIteration1[j-1];
                            ++a.NotesInIteration2[j-1];
                            break;
                        }
                    } 

As you can see, the condition used to count the chords as notes in the phrase iteration seems to be a bit more restrictive in the current code than in the v2.3.0.0.

 

To count the single notes the condition is always the same ( "if (piter.Time > note.Time)" ).

 

That could explain why we have different behaviours depending on the number of chords that an arrangement contains ...




#232284 Remastered messed up scoring?

Posted by Chlipouni on 08 October 2016 - 05:32 PM

@Alex360,

 

  We have just found that RSToolkit v2.2.2.0 & v2.3.0.0 are able to generate CDLCs without the 100% scoring bug !

 

  So we are simply trying to help to find the reason  :)

 

@Biermeister 44

 

  I am using the last release of EOF and I am able to generate the CDLC with the RSToolkit v2.2.2.0




#232262 Remastered messed up scoring?

Posted by Chlipouni on 08 October 2016 - 03:44 PM

@cozy1,

 

  I used the same process to generate the CDLC with RST v2.2.2.0 and RST v2.7.1.0 :

  - No bug with v2.2

  - Bug still present with v2.7

 

  In my opinion, we should identify the main release of RST that has broken the scoring logic, and simply compare the two versions of code to identify the reason.




#232253 Remastered messed up scoring?

Posted by Chlipouni on 08 October 2016 - 03:21 PM

@Chlipouni et.al.  I just posted a new toolkit beta version  2.7.1.0-53552b41 - 100% Bug Issues.

 

I removed the 'Techniques' section from the JSON Manifests files so that you and others can test CDLC with the new toolkkit.

 

You should be able to use the "CDLC Creator" tab "Import Package" feature to revise existing CDLC that experience the 100% bug (change the CDLC version number in the GUI).  Click 'Generate' and when prompted assign a new  'Arrangement Identification'.  The 'Techniques' section will not be generated/written.  Then test the revised CDLC for the 100% bug.

 

I have tried the Beta release with my CDLC and bad news, the bug is still present  :huh:

JSON file comparison (2.7.1.0 100% Bug Issues / 2.2.2.0) :

- "Metronome": 0,           in 2.7.1.0 only
- "Tone_Multiplayer": "",   in 2.7.1.0 only
- "Tones" section           Completly defined in 2.7.1.0 / null in 2.2.2.0
- "Metronome": 0,           in 2.7.1.0 only

 Except the "Tones" section the other changes are minor (In my opinion).

 

 Are there other files that may have differences ?

 

Thanks




#232217 Remastered messed up scoring?

Posted by Chlipouni on 08 October 2016 - 12:45 PM

How do you get a hold of 2.2.2.0?

 

On the builds page it does not go back that far :(

 

https://www.rscustom.net/builds#

 

I always keep a few releases of the tools we are using.

 

That gives me a way to identify the regressions more quickly  :P

 

Do you want the 2.2.2 Release ?




#232197 Remastered messed up scoring?

Posted by Chlipouni on 08 October 2016 - 11:33 AM

Hi,

 

  I have just tested the following cases on my last CDLC :

 

  1) Toolkit 2.7.1.0 : 100% scoring bug

  2) Toolkit 2.2.0.0 : All works fine !

 

  Then I have made a comparison of the XML and JSON files :

  

  XML : no differences

  JSON  : 

     - Ids are different (seems normal)

     - Techniques section is defined in 2.7.1.0 but not in 2.2.0.

     - Tones section is complete in 2.7.1.0 and equals "null" in 2.2.0.0

 

  In my opinion, the bug seems to be related to the "Techniques" section.

 

  That explains why Billkwando reported a similar issue for RS2014 first edition two weeks ago (in DDC topic) ...

 

At least, while we are waiting a fix, we still can produce CDLCs that work with RST v2.2 :rolleyes:




#231957 Remastered messed up scoring?

Posted by Chlipouni on 07 October 2016 - 12:59 AM

@firekorn,

I made a quick comparison between XML files in the two releases of the songs.psarc official file and I found changes ...

So it seems that Ubi has made some modifications in their songs ...




#231860 Remastered messed up scoring?

Posted by Chlipouni on 06 October 2016 - 04:05 PM

One week before RS2014 Remastered Update, Billkwando had reported a similar issue in one of his CDLC : Post in DDC topic

 

So, RS2014 first edition seems to have the same issue (but less frequent)