Chlipouni

I tried to modify DDC logic in order to allow the first beat to be on higher time position than "0.000".

The result package works in RS2014, but I have the following strange behaviours :

- The first phrase can be selected in the Riff Repeater, and I can change the DD Level for this phrase, but the purple box isn't displayed anymore !

- The first anchor of this phrase starts at the 15th fret, but the camera position is blocked on the first fret !

You can download the project here : Test - Test

- In the EOF subfolder, you can find the EOF project

- In the Toolkit subfolder, there is the "REAL PART_REAL_GUITAR_RS2.xml" file generated with DDC v3.6 (not yet released)

I need help to discover what is going wrong ...

Thanks

@@firekorn,

  Thank you for the detailed description of this issue.

  I think that I can change DDC behaviour to correctly manage the leading silence.

  I noticed that EOF never sets the "offset" and "centOffset" XML tags (they are setted in ODLCs).

  Do you know if these tags have a role to play in this issue ?

Thanks

@@Karmeleaux your PC is old and slow? I've got significant delay in graphics part of the tone change after I manually switch it I can hear it faster than amps drop down or sometimes it takes some time to load tone to the rs input mixer, but for powerful PC\MAC you won't met those circumstances at all. and yes @@iminashi has tools to fix ddc work after, not sure why @@Chlipouni haven't fixed at leas 0 sec bug yet?

Hi Alex,

  Simply because I didn't know that bug ;)

@@raynebc,

  I don't remember if "Import/Lyrics" works with accented characters.

  If my input lyrics file contains "é", it is not imported correctly in EOF. If I directly type it in EOF, it is correctly displayed.

  Do I need to use a special encoding setting for my input file ?

Thanks

It is mainly about the highlighting of the selected graphical bar in the piano roll area.

Thanks

I have no specific preference for the selected bar colour.

Just something that highlights them more ... 

Some ideas to improve the PART_VOCALS track in EOF :

1) Selection

It is difficult to select a lyric's bar in the PART_VOCALS arrangement.

The selection works only when the mouse is on the beginning of the bar. Is it possible to allow it on the whole bar area ?

2) Colours

Another improvement is about the colour used to identify the selected bar. It is to close to the non-selected ones.

Thanks

2.8.4.1-4ed91936-win though I also used older versions with same results

I have found the bug about DDC v3.4 and "ddc_dd_remover.xml" template.

New release will coming in the following days ...

Thank you

@@theSG, for your information, DD remover simply copy all elements found in the "transcriptionTrack" tag into the first level of difficulty. If this tag is empty then DDC generates it by using a merge of all DD levels.

Maybe there is a bug in DDC, but I need time to investigate. If you have a simple EOF project with this issue please share it.

Thanks

Envoyé de mon SM-G920F en utilisant Tapatalk

@@theSG, both files contain the same "ebeats" elements that define beats and measures.

When you say that there are missing measures, can you explain a bit more what are the differences ?

Can you give me time positions where you see some differences ?

Thank you

I just tried to use dd remover and it completely removes some measures from the arrangement.

Can you share the XML or PSARC file ?

This was an issue that @@I)ark_Seph mentioned to me.

 

Here's an example XML:

https://drive.google.com/open?id=1Pk4yEd8KB2vDTFTVX7Z5HXJEVQK5c9Rq

 

DDC will create a new empty phrase at 5.167, which breaks the handshape in game.

 

 

Somewhat related, I noticed that in one of my own customs there is an 8 bar phrase that ends with three empty bars and then a single sustained note. DDC creates an empty phrase for the three empty bars and places the last note into its own phrase. I guess I can live with that, though it is a bit silly to have a phrase with just one note in it.

  About the issue identified by @@I)ark_Seph, it should be solved by the last EOF hotfix (7-11-2018).

Thanks

@@raynebc,

  The logic seems fine for me.

  I didn't know what action to use to remove the warning message.

Thanks

@@raynebc,

  I tried the beta release with the following example :

  EOF - Chords - HandShapes 2

  The XML code is :

    <level difficulty="0">
      <notes count="3">
        <note time="6.443" string="1" fret="3" sustain="1.088" slideTo="7" />
        <note time="6.443" string="2" fret="5" sustain="1.088" slideTo="9" />
        <note time="6.443" string="3" fret="5" sustain="1.088" slideTo="9" />
      </notes>
      <chords count="2">
        <chord time="5.352" chordId="0" linkNext="1" >
          <chordNote time="5.352" string="1" fret="3" sustain="1.091" linkNext="1" leftHand="1" />
          <chordNote time="5.352" string="2" fret="5" sustain="1.091" linkNext="1" leftHand="3" />
          <chordNote time="5.352" string="3" fret="5" sustain="1.091" linkNext="1" leftHand="4" />
        </chord>
        <chord time="7.534" chordId="1" >
          <chordNote time="7.534" string="1" fret="7" leftHand="1" />
          <chordNote time="7.534" string="2" fret="9" leftHand="3" />
          <chordNote time="7.534" string="3" fret="9" leftHand="4" />
        </chord>
      </chords>
      <fretHandMutes count="0"/>
      <anchors count="1">
        <anchor time="5.352" fret="3" width="7.000"/>
      </anchors>
      <handShapes count="2">
        <handShape chordId="0" startTime="5.352" endTime="7.531"/>
        <handShape chordId="1" startTime="7.534" endTime="8.080"/>
      </handShapes>
    </level> 

  The first handShape tag includes correctly the second chord, so this problem is solved.

  As you can see, I added a third chord that starts on the 7 fret. This new chord is not fully included in the current anchor tag, but EOF doesn't generate a new anchor tag for it.

  Instead of that, EOF displays this warning : "This note is specified as using the index finger, but the first hand position is on a different fret....".

  Is it normal ?

  If yes, how can I solve this ?

  If I remove the linkNext status on the first chord, the new XML code becomes :

    <level difficulty="0">
      <notes count="0"/>
      <chords count="3">
        <chord time="5.352" chordId="0" >
          <chordNote time="5.352" string="1" fret="3" leftHand="1" />
          <chordNote time="5.352" string="2" fret="5" leftHand="3" />
          <chordNote time="5.352" string="3" fret="5" leftHand="4" />
        </chord>
        <chord time="6.443" chordId="0" >
          <chordNote time="6.443" string="1" fret="3" sustain="1.088" slideTo="7" leftHand="1" />
          <chordNote time="6.443" string="2" fret="5" sustain="1.088" slideTo="9" leftHand="3" />
          <chordNote time="6.443" string="3" fret="5" sustain="1.088" slideTo="9" leftHand="4" />
        </chord>
        <chord time="7.534" chordId="1" >
          <chordNote time="7.534" string="1" fret="7" leftHand="1" />
          <chordNote time="7.534" string="2" fret="9" leftHand="3" />
          <chordNote time="7.534" string="3" fret="9" leftHand="4" />
        </chord>
      </chords>
      <fretHandMutes count="0"/>
      <anchors count="1">
        <anchor time="5.352" fret="3" width="7.000"/>
      </anchors>
      <handShapes count="3">
        <handShape chordId="0" startTime="5.352" endTime="6.440"/>
        <handShape chordId="0" startTime="6.443" endTime="7.531"/>
        <handShape chordId="1" startTime="7.534" endTime="8.080"/>
      </handShapes>
    </level>

  In this specific case, EOF creates a new handShape to manage the second chord, but it should be able to reuse the previous handShape (because they both have the same chordId).

Thank you

@@raynebc,

  Let's take the following example with two C5 chords :

  EOF - screenshot

  I obtain the following XML code :

    <level difficulty="0">
      <notes count="0"/>
      <chords count="2">
        <chord time="5.352" chordId="0" >
          <chordNote time="5.352" string="1" fret="3" leftHand="1" />
          <chordNote time="5.352" string="2" fret="5" leftHand="3" />
          <chordNote time="5.352" string="3" fret="5" leftHand="4" />
        </chord>
        <chord time="6.443" chordId="0" highDensity="1" >
          <chordNote time="6.443" string="1" fret="3" leftHand="1" />
          <chordNote time="6.443" string="2" fret="5" leftHand="3" />
          <chordNote time="6.443" string="3" fret="5" leftHand="4" />
        </chord>
      </chords>
      <fretHandMutes count="0"/>
      <anchors count="1">
        <anchor time="5.352" fret="3" width="4.000"/>
      </anchors>
      <handShapes count="1">
        <handShape chordId="0" startTime="5.352" endTime="7.534"/>
      </handShapes>
    </level>

  The two chords are generated and the handShape includes both of them.

  If I add a LinkNext status on the first chord, the XML code becomes :

    <level difficulty="0">
      <notes count="0"/>
      <chords count="1">
        <chord time="5.352" chordId="0" linkNext="1" >
          <chordNote time="5.352" string="1" fret="3" sustain="2.182" leftHand="1" />
          <chordNote time="5.352" string="2" fret="5" sustain="2.182" leftHand="3" />
          <chordNote time="5.352" string="3" fret="5" sustain="2.182" leftHand="4" />
        </chord>
      </chords>
      <fretHandMutes count="0"/>
      <anchors count="1">
        <anchor time="5.352" fret="3" width="4.000"/>
      </anchors>
      <handShapes count="1">
        <handShape chordId="0" startTime="5.352" endTime="6.443"/>
      </handShapes>
    </level>

  Only one chord is generated and it includes the second one with its sustain (OK for me).

  But the handShape doesn't include the second chord anymore.

  If I add a split status on the second chord, the XML code becomes :

    <level difficulty="0">
      <notes count="3">
        <note time="6.443" string="1" fret="3" sustain="1.091" />
        <note time="6.443" string="2" fret="5" sustain="1.091" />
        <note time="6.443" string="3" fret="5" sustain="1.091" />
      </notes>
      <chords count="1">
        <chord time="5.352" chordId="0" linkNext="1" >
          <chordNote time="5.352" string="1" fret="3" sustain="2.182" leftHand="1" />
          <chordNote time="5.352" string="2" fret="5" sustain="2.182" leftHand="3" />
          <chordNote time="5.352" string="3" fret="5" sustain="2.182" leftHand="4" />
        </chord>
      </chords>
      <fretHandMutes count="0"/>
      <anchors count="1">
        <anchor time="5.352" fret="3" width="4.000"/>
      </anchors>
      <handShapes count="1">
        <handShape chordId="0" startTime="5.352" endTime="6.443"/>
      </handShapes>
    </level>

  The second chord is generated as single notes as expected, and the first chord has a sustain that includes the single notes.

  In this third case, the handShape only includes the first chord.

  Finally, If I replace the split status with a slide, I obtain the same behaviour about the handShape.

  In conclusion, when I use the LinkNext status, EOF doesn't generate a handShape for the second chord and it omits to include it in the existing one.

  PS : About the second issue (single notes duplicated), I can't reproduce it with freshly created files.

Thanks

Hi @@iminashi,

  After analyzing your requests :

  - DDC generates an handShape when a least two different notes that belong to it are displayed. So for the case of the "noguitar" section, you just need to check that the handShape is not empty.

  - For the end of the song DDC generates a "noguitar" section after the last event (note, chord, sustain, handShape endTime).

  So you may encounter issues if the handShape is empty (no note neither chord inside). Is it the case ?

Thank you

I asked @@raynebc to include the single notes in the same handShape as the previous chord.

Hi @@raynebc,

  I have a request about the automatic handshape management when "linkNext" status is used between two chords.

  Let's take the following example (XML extract) :

<notes>
  <note time="134.893" string="1" fret="8" sustain="0.208" slideUnpitchTo="7" />
  <note time="134.893" string="2" fret="10" sustain="0.208" slideUnpitchTo="9" />
  <note time="134.893" string="3" fret="10" sustain="0.208" slideUnpitchTo="9" />
</notes>
<chords>
  <chord time="134.259" chordId="6" linkNext="1" >
    <chordNote time="134.259" string="1" fret="8" sustain="0.634" linkNext="1" leftHand="1" />
    <chordNote time="134.259" string="2" fret="10" sustain="0.634" linkNext="1" leftHand="3" />
    <chordNote time="134.259" string="3" fret="10" sustain="0.634" linkNext="1" leftHand="4" />
  </chord>
</chords>
<handShapes>
  <handShape chordId="6" startTime="134.259" endTime="134.893"/>
</handShapes>

 When two chords are linked together, the second one is converted as single notes at the same time position, but the handShape ends at the beginning of these single notes.

 If I remove the "linkNext" status, the handShape will include the second chord.

 So is it possible to include these single notes in the same handShape as the previous chord ?

 In DDC I use the following logic to decide if a single note belongs to an handShape : startTime <= note time < endTime

 It was mandatory for me to do that because it is possible to have the endTime of an handShape equals to the startTime of the following one.

 PS : I think that EOF generates duplicates in single notes (import an XML file that already contains this logic and save it)

Thanks

@@iminashi,

  DDC manages correctly this case only if the single notes (more than one at the same time position) are located in the same handshape as the previous chord.

  In DDC, a single note belongs to an handshape only if : startTime <= note time < endTime

  I use this logic, because until now, the endTime of an handshape could be equal to the startTime of the following one.

  So in the aaron5015's XML file, the single notes are not located in the same handshape because their time position is equal to the endTime.

  If I update manually the endTime (+1) of this handshape, DDC works fine.

  Do you have knowledge about handshapes ?

  Is it still possible to have the endTime of an handshape equals to the startTime of the following one ?

Thanks

Hi aaron5015,

  Can you share the XML file generated by EOF for this arrangement ?

Thanks

Thanks a lot for the new "Beat>Anchor measures" feature  ;) 

Yes, only the first beat of each measure should have an anchor.

For this new function, the process should be :

- put an anchor on the first beat of all measures

- remove all anchors on secondary beats 

- redistribute the secondary beats and the notes inside their measure (the same way EOF does when I move the main beat of a measure)

For the moment, I do it manually for all measures.

As an example, here is the situation after importing the GPA tab :

Picture n°1

After managing the anchors :

Picture n°2

Hi raynebc,

  I am using Go PlayAlong 4 to automatically synchronize the tab with the soundtrack.

  When I import the result in EOF, I have a lot of anchors on the secondary beats and for me it's normal.

  Is it possible to add a new function in EOF to :

  - add an anchor on all main beats that don't already have one

  - remove all anchors on secondary beats (with automatic evenly spaced beats inside the measure)

  So , in conclusion, I don't want you to modify the current import function, but just adding a new one to clean the anchors on secondary beats.

  After applying this new function, it will be simpler to adjust the main beats for a perfect synced track with the minimum anchors needed.

Thanks a lot for all of your work !

@@iminashi,

  Thanks for the explanations.

  I have a lot of work in the two next weeks.

  I will study your requests as soon as possible.