iminashi

@@iminashi, I altered it a bit, please validate it's working for you too ;)

The custom that was giving me the error now builds, so should be fixed. Thanks.  :)

@@cozy1

The sequence of notes might have an effect on things. I haven't really tested that. For the screenshots I used two files that had all of the particular notes one after the other. For the fog screenshots, one 42 and then 24-35. For the beam ones I had one 25 and then 48-59 one after the other.

I was about to let you know that there is bug in AdjustShowlights. If the last note on the showlight list happens to be one of the bad notes, it will result in an "index out of bounds". Changing the foreach loop into an if statement would be one way to fix it:

if (showlightList[i].Note > 35 && showlightList[i].Note < 48 && showlightList[i].Note != 42)
{
     showlightList.Remove(showlightList[i]);
     continue;
}

For anyone interested, here are screenshots of the showlights:

https://drive.google.com/open?id=0B_0HDnEbZi4PTWF1bVl2SXdZVlE

There are two screenshots of 35. I have no clue why the first one (the glitched one) was green + purple.

In the screenshots for the fog colors, beams and laser lights were off. In the screenshots for the beams, the laser lights are on and the fog color was 25.

The exact names of the colors aside, in the note key in the toolkit showlight editor, 33 and 34 should be switched. 33 is a blue color and 34 is a yellow color. 

Also, the exact number and type of lights affected by 42,48-59 depends on the venue. My screenshots were from a small venue, but in some venues they also affect the color of a moving light/lights.

@@iminashi. I also unable to reproduce stroboscope effect from one of Rise against songs It would be cool to get one!

I guess it's binary masks but it's ok to operate them in numerical form so not a big deal here.

Which song is it? I'd like to see it myself.  :)

 

Is there a corresponding off note for fog like 42 is for beams?

I don't think so. There are zero hits in the XML files for notes 0-23 and 36-41.

@@cozy1 You released a new version just as I was writing a reply.  :)

I'll need to test the new version to see if what I was about to write still stands. One thing I noticed with the code is: shouldn't rnd.Next(48, 59) be rnd.Next(48, 60) in order to get a random number between 48-59 (ditto for 24-35)? Or maybe I'm reading the wrong documentation...  :)

I haven't come across ODLC that uses other than alphanumeric characters for phrase names. Usually they are short like "A", "B", "C", but there are also names like "solo2".

@@iminashi

Have you seen ODLC where two showlights notes appear at the same time as in your example?

 

<showlights count="2">

<showlight time="66.646" note="35" />

<showlight time="66.646" note="59" />

</showlights>

 

I ask, because I have not.

That was actually a mistake I made as I copy pasted, but they are out there.  For example "All I Wanna Do" starts with 

  <showlight time="10.000" note="24"/>
  <showlight time="10.000" note="52"/>

so @@iminashi is saying that all official DLC starts around the 10 seconds mark? damn i thought it was starting around like 6/7 seconds... I might have to change some stuff i do then.

There is a little over 10 seconds of silence at the start of an ODLC and the beatmap usually starts at exactly 10 seconds. Try importing some of them into EOF and check for yourself. But in the game it doesn't take 10 seconds for the song to start. I've been wondering how that works.

I'll need to do some more testing and fiddling with the showlights, but here is my uneducated guess on why it crashes.

The total number of showlights and how early they need to be set doesn't seem to matter. In official content the first showlight note is almost always at 10.000, which is where the beatmap begins in most official content, but the game doesn't crash if there are no showlight notes at the beginning. And the minimum number of showlight notes you need seems to be 2.

There needs to be at least one note from the fog color set (24-35) and one note from the spotlights/effects set (42, 48-59). The game loads them into tables or lists or whatever and the programmers hadn't prepared for the case where they have zero entries, causing the game to crash.

I have tested the following showlights files and they didn't crash the game for me (the notes are set at a time that is very near to the end of the audio): 

<showlights count="2">
  <showlight time="63.455" note="32" />
  <showlight time="66.646" note="55" />
</showlights>


<showlights count="2">
  <showlight time="66.646" note="24" />
  <showlight time="66.646" note="42" />
</showlights>


<showlights count="2">
  <showlight time="66.646" note="35" />
  <showlight time="66.646" note="59" />
</showlights>

I did some testing with my two crashing CDLC.

In the first showlights file, there were no notes from the 42-59 range. I tried adding one 42 at the beginning and the crash was gone.

As for the second showlights file, there were two notes from the 42-59 range near the end. 43 and 45. At first I thought they came too late in the song or something, but I tried adding the note 55 (which I happened to choose randomly) between them, and that got rid of the crash.

Then I ran search in the showlights XML files from the on-disc songs, imported RS1 songs and DLC and the RS2014 DLC I own. While there are 1207 hits for the note 42, there are zero hits for the notes 43-47.

Editing the showlights file and just changing the note 45 to 55 fixes the crash.

I got around to testing this (I was playing "Carry On Wayward Son" which also has these).

It works: http://i.imgur.com/8Ye6XAv.gifv

Here are some files: https://drive.google.com/open?id=0B_0HDnEbZi4PZnhOendwVFdmakE

I combined the rhythm and lead arrangements to make the ChordInsideArpeggio XML. It has two handshapes in it. The chord handshape is inside the arpeggio handshape, but it will not displayed; the arpeggio handshape seems to override it. However, it has to be there, without that handshape all you will get is a high-density chord box.

The two CDLC that I updated today also crash after tuning when I build them with the latest version of the toolkit. I haven't had time to look into it more closely, but the culprit are the showlights (yet again). Using the showlights file from the previous, working version of the CDLC, they don't crash.

Try using an older revision of the toolkit and see if that works.

 

This should be fix now.  Can you confirm?

 

It works, but it's not foolproof since one can change the name of the vocals track in EOF.

 

Something about the included XMLs are crashing RS

 

https://drive.google.com/file/d/0B2oZs0ta32KyZHpGZHltcy0tVEk/view?usp=sharing

 

I just don't know what.

 

I build the custom with bass and vocals and it works.  I include Rhythm or Lead and the custom plays the intro music, but as soon as you press "go" it fails and locks the game up.

 

Any help would be great :D

This is what I was going for:

http://i.imgur.com/nLw6FMl.jpg

But I guess I might as well use fret-hand muted chords instead of single notes.

Came across another problem. Generating DD on this arrangement causes some of the handshapes to point to the wrong chordId, with the first one pointing to chordId -1.

https://drive.google.com/open?id=0B_0HDnEbZi4PSGo4MDJhbjloSTQ

On another topic, I updated the toolkit to the latest beta (the one released yesterday) and it wasn't accepting lyrics files (that I was producing with the 4-17-2017 release of EoF) that older versions of the toolkit did when I reverted. Anyone else having a problem with this, and know if it's an incompatibility issue or a problem with the toolkit?

It's a toolkit problem. Currently it will only accept lyrics files that end with "vocals.xml".

And another update with 6 more shapes, including a pretty common power chord shape that I had somehow missed.

Can anyone get a comma to work within lyrics with the latest release?

Looks like commas etc. work only if there are extended ASCII characters in the lyrics. I haven't really missed commas, but I'd like to be able to use double quotes and parentheses without having to edit the lyrics files manually.

Uploaded a new version with 6 more shapes.

@iminashi  If raynebc hard codes these character substitutions, would this prevent users from being able to use custom lyric font DDS files with the toolkit? 

 

Seems like users may want the option in EOF to not use any character substitutions in case the user wants to create and use a custom lyric font DDS file.

I don't think anybody uses custom fonts since there are no tools out that would ease the process.

Substituting the characters that can't be used is a good idea I think. Having a non-accented character is better than no character at all.

Whats a UTF file, is it something normal EoF users can get?

Does anybody know if RS1 supported extended ASCII?

It does, "Gobbledigook" and "Icky Thumb" use extended characters in RS1.

I'd also be interested in knowing if the "noguitar" section should continue to be added automatically to the RS XML files if it isn't manually authored in the chart.

In ODLC the END phrase is accompanied by a noguitar section if that's what you mean. Speaking of which, EOF should probably place the END phrase on the first beat of a bar so that DDC won't move it.