iminashi

Uploaded version 1.1 with the following changes:

• Made the program localizable and added Japanese and Finnish translations
• Added the possibility to open .txt files in which case the program will generate a font from all the unique characters in the file
• Added "Spacing Adjustment" setting to the advanced options. Lower this value if you think the characters are too far apart (although you won't know until you try the font in game)
• Added option to use a dark theme

I'd like to point out that there's no need to edit the maingame.csv when you add custom tunings (unless you want to localize the text).

You can just put the name straight into UIName, e.g:

"UIName" : "B Drop A",

Guess that is why I had added that comment to the code.  Any suggestions for the code revision?

Set it to arrangement.ArrangementPropeties.Represent? Is there a chance that it might not be set correctly at this point?

There appears to be a bug when setting Representative in the header file.

https://github.com/rscustom/rocksmith-custom-song-toolkit/blob/dfeda5a604de0d3fe7bacaf4699f78ebe8d0b74b/RocksmithToolkitLib/DLCPackage/Manifest2014/Header/AttributesHeader2014.cs#L142

There's definitely something wrong with the template file since it has a vocals arrangement that's called "Lead".

By removing and re-adding all the arrangements I was able to build a psarc that didn't crash.

According to the xml comments in the files, you have Toolkit version 2.8.0.0 which is too old to work with the abridged xml feature.

Just select all the same chords and the notes in between and mark a handshape (Ctrl+Shift+H).

Thanks for input.  Are you able to reproduce the vanishing 'Song Information'?  I have not been able to do so. 

I am able to reproduce it with a file dialog and double clicking, like I described in the issue I linked.

Selecting a file and then hitting enter or clicking the "open" button will not cause it to happen.

Also, this might  be related, but when I'm generating a custom in RST, I'll select the bass part, then when I go to choose the album art or music file, it clears all the fields. There's no rhyme or reason to this - if I select the music file first, then the bass part, selecting the album art can still clear everything. Sometimes it works, other times it can take five or six attempts to get everything to stay put.

That sound a lot like this bug.

Where do I ignore them, and will the notes disappear? 

In EOF, in the edit note window, or Ctrl+Shift+I. The notes will still be there, they just don't count toward the total accuracy even if you miss them.

Notes on the 23rd and 24th frets are ignored automatically, but since the Remastered update, if they are not set as ignored they will mess up the mastery rating.

If the CDLC has notes on the 23rd or 24th frets, then that's the reason. They need to be set as ignored and newer versions of EOF will do that automatically.

Uploaded version 2.1.

I think adding those notes makes the Toolkit generate a showlight file that crashes the game. You should update your Toolkit to a newer version.

@@firekorn Sure, I'll add that option.

It probably wouldn't be very hard for me to change the RS export behavior so that the first beat starts at 0s and the offset tag is written. Let me know if it's actually useful for me to do this for the toolkit's sake though.

The first beat should be where it is, not at 0s. As for offset, might as well write it, in the case that a future update to the game suddenly requires it to be correct in the SNG file.  :)

An arrangement needs to start with an empty phrase, otherwise that will happen. EOF creates one called "COUNT" but the actual name doesn't matter.

There is not a free beat for EOF to create the phrase in your project.

In the PART_REAL_GUITAR_RS2.xml with DD there is a COUNT phrase but there is not a phrase iteration for it.

Offset is used for the StartTime metadata value in the SNG files.

https://github.com/rscustom/rocksmith-custom-song-toolkit/blob/master/RocksmithToolkitLib/Sng/Sng2014FileWriter.cs#L210

"offset" probably doesn't do anything. In any case, the Toolkit sets it correctly in the manifest files even if it's not set in the XML.

"centOffset" definitely isn't related to this issue.

I tested it and the tone change itself happens at the correct time, only the "tone switch" text comes late.

It may be due to the difficulty setting stuff the game displays at the beginning of a song (or not).

Adding more leading silence might fix it.

v2.0 is up. There are a few new features and bugfixes.

 Periods "." are not valid in sortable fields.

They are actually. This can be easily fixed by filtering out the periods somewhere. Here, for example.

Represent is either 1 or 0. If it's 1 then it's the main arrangement for the path (rhythm, lead, bass) and its stats will be the ones displayed in the Learn a Song list and elsewhere.

The "represent" attribute would be used for that.

 

I was just thinking the other day that I knew there was something broken and weird with ignores, but I couldn't remember what.

 

So this issue aside, there is no problem with using ignores (in relation to them messing up scores or the percentage when completing the song)?

One thing what I find weird about ignores is that the game won't display "miss" but may display "late".

Hopefully all the bugs with ignore are fixed. The issue where any ignores you would cause wrong mastery was fixed a long time ago and a while back, I fixed another bug that had to do with calculating the total notes in a song, but I don't know if that one actually caused any problems in practice. In any case it should match ODLC now so any possible updates to the game shouldn't break things either.

Bump. This is still an issue.

EOF should definitely export 23rd and 24th fret notes with an ignore status automatically.