Latest EOF releases (9-26-2020)

[Unleashed2k]

I'm interested in the slide to unpitch slide. It would help a lot.

[PC Plum]

If this slide to unpitched slide goes ahead, I suggest stopping the unpitched slide 2 frets before the normal slide end.  Just to keep charts neat, its horible when the unpitched goes on to end on the resolving frett and then another note on that fret is played.

[albatross213]

If this slide to unpitched slide goes ahead, I suggest stopping the unpitched slide 2 frets before the normal slide end.  Just to keep charts neat, its horible when the unpitched goes on to end on the resolving frett and then another note on that fret is played.

That sounds like the kind of thing that's too specific to be implemented as stated (what if the slide is two frets or less?), and I'm not sure everyone would want that particular number. A nice fix I could think of would be something like how you can use the scroll wheel to increment the fret number of a selection of notes, but instead it would only affect the end note of slides within the selection.

 

No idea whether that would be hard to code, but I'd guess that if the modification from pitched to unpitched within a selection is possible then something like this would be possible as well.

[raynebc]

I could probably add the ability for CTRL+SHIFT+Scroll to change a slide note's end fret (if grid snap is enabled). This control only has a unique use for when grid snap is disabled.

[Alex360]

@@raynebc, I wonder if we could get trem status for chords and notes as real statuses eg. vibratto\harm\accent since it's not about rhythm games anymore? can you alter this for PRO tracks? or add separate func for rs only tracks if RB doing things old way?

It's just bugging me off about this thing, I move note and I should redid whole mapping again :(

[raynebc]

I'll have to put some thought into how to best handle that. I don't want to drop support for RB3 pro guitar notations, but having phrases not move with moved notes is kind of a nuisance.

[Aludog]

With RB4 coming out soon I can see how it might be problematic to drop support for that kind of notation right now. I definitely would appreciate the change for RS status marking though and so would a lot of others, I guess. It would come in handy at times but I admittedly won't need it often. If you find a solution, that's great; if not, that's fine as well.

[PC Plum]

Hi,

 

r1436 does not unpack the repeats at all

 

http://tabs.ultimate-guitar.com/r/ralph_mctell/streets_of_london_ver2_guitar_pro.htm

 

It seems to play fine in GP and so I was wondering if it were a problem with EoF?

 

 

 

Thanks :D

 

 

 

Edit - r1341 does not unpack it either, so I'm guessing a problem with the GP file.  If you could confirm this before I spend a few hours manually fixing it that would be great :D

 

 

Double Edit - I saved the downloaded GP4 as a GP5 and it imports fine (in r1436).  Must just be a problem with .gp4 files.

[raynebc]

I took a look at the file and the problem is due to one of the major deficiencies of the Guitar Pro 4 format: Alternate endings. In other versions of the format (or at least version 5), if an alternate ending applied to the first and second pass, that would be encoded in the GP file as the binary value 11b. This the right-most 1 means the measure was used in the first pass, and the second to right-most 1 means the measure was used in the second pass. This makes sense, right? In GP4 format, it encoded the value as 2 as if to say that measure is used in pass numbers 2 and below. Then if the next measure applies to passes 3 and 4, its alternate ending is encoded as 4 as if to say it applies to all passes 4 and below, except for passes 2 and below because of the previously encoded alternate ending.

 

This notation greatly complicates things and even means that certain alternate ending patterns are difficult or maybe even impossible to author in GP4 unless measures and alternate endings are defined in an agreeable order. I'll change the logic a bit to try to allow this file to import, but any kind of elaborately structured tabs will be better off in GP5 format.

[SmellyOrc]

Wouldn't it be easier to save a gp4 file as a gp5 file? Guitar Pro 6 at least supports this. 

[PC Plum]

Yeah man, no worries.  Don't go messing about, it takes seconds to save as a GP5 now I know there is a problem with GP4 :D

 

 

There are actually more fundamental problems with this GP tab, to do with the structure (when compared directly to the recorded version) and the actual tabs themselves.  I've gotten so far, but I'll need to work up the effort required to finish it.

 

 

 

Thanks again for having a look.

[th1rtyf0ur]

Looks like google code is now read-only. Will the code base be moved somewhere else? Was going to make a feature request but can't add any issues anymore. :D

[th1rtyf0ur]

Was going to hold off on the feature request, but there's a weird bug I can't ignore. I've had a few songs where the very last chord's notes all change to 0s for some reason, and I can't figure out why or how it's happening. Like, the song will end with a bunch of chords like --577- but the very last one will be --000-. Anyone else ever have this problem? I've had it happen on at least 2 songs now.

[raynebc]

The code has been brought over to Github (https://github.com/raynebc/editor-on-fire), I just haven't gotten around to making another commit yet. I'm still a little butthurt at having to give up on how easy to use Google Code and SVN have been.

 

Regarding the bug you mentioned, if you can provide a project file (the simpler the better) that creates this phenomenon during save (and this is visible in the XML file), it will help me fix the problem.

[th1rtyf0ur]

I'm seeing r1397 on github while google had r1437... although the only difference appears to be in src/makefile.macosx

 

Anyway, I'll try to recreate the error, but not sure how... I've already fixed both of the songs & there were so many edits that I don't even know when it happened. -_-;

[raynebc]

Github didn't retain commits that involved the /wiki branch from Google Code, which is the reason for the discrepancy. I spent a lot of time trying to figure out how to get a perfect 1 to 1 transfer. It wasn't feasible.

[PC Plum]

I was wondering if you could take a look at something?

 

I made this

 

https://drive.google.com/file/d/0B2oZs0ta32KyVGZtS2dfQWE1bnc/view?usp=sharing

 

and it comes in game like this

 

https://drive.google.com/file/d/0B2oZs0ta32KycW1QQk5xTDFVRkk/view?usp=sharing

 

and I was wondering why there is a chord tail?  Another resulting effect of this (in my game anyway) is that the G chord fingering (1, 3) stays on screen for the duration of the muted chords, even though the fingering is nowhere near the fhps

 

https://drive.google.com/file/d/0B2oZs0ta32KyM1dsLWg1UmZvRlE/view?usp=sharing

 

Strangely, Xyber made a vid (you can see it in the song thread if you like, I don't want to post vids in this thread) and although he has chord tails he does not get the extended fingering graphic.

 

 

It's quite nippy, some help would be appreciated.

 

 

EoF File

 

https://www.sendspace.com/file/pipvug

 

Resulting XML

 

https://www.sendspace.com/file/0oq86e

 

 

 

 

And it's 1436 I'm using.

 

 

Thanks :D

[PC Plum]

May as well make it a double whammy...

 

I had some strange stuff last night making this but I put it down to a one off, but now I see there is a problem.  Last night I tried to pull this arrangement into the toolkit and the toolkit gave me an error.  When I checked out this error, EoF had written an unpitched slide to fret 255 even though in the EoF project it clearly said unpitched slide to 6 (from 8).  Unfortunately I've overwritten the files now, but I can show you this

 

https://drive.google.com/file/d/0B2oZs0ta32KyelRSS1pOWGlBVTA/view?usp=sharing

 

https://drive.google.com/file/d/0B2oZs0ta32KySk1NTHEyV2ZUeEk/view?usp=sharing

 

I can't see anything wrong with the EoF authoring, but in game it comes out wrong.  For the record, EoF won't let me make it a slide up to fret 5 (if EoF is now taking the starting point from the highest string and hence why it tries to go up to fret 9) so I definitely authored it correctly.

 

 

EoF

 

https://drive.google.com/file/d/0B2oZs0ta32KySk1NTHEyV2ZUeEk/view?usp=sharing

 

XML

 

https://drive.google.com/file/d/0B2oZs0ta32KySk1NTHEyV2ZUeEk/view?usp=sharing

 

 

 

Thanks again :D

 

 

 

 

Here's another example from the same project

 

https://drive.google.com/file/d/0B2oZs0ta32KyS2xxRW14MzZFanc/view?usp=sharing

 

https://drive.google.com/file/d/0B2oZs0ta32KyVFdlbGV0aHo2MEk/view?usp=sharing

 

 

EoF is consistently adding 2 extra frets when sliding up to a linknext.  Furthermore, its when the slide is using two different frets, for example

 

https://drive.google.com/file/d/0B2oZs0ta32KyUTJrT20tRm56elU/view?usp=sharing

 

https://drive.google.com/file/d/0B2oZs0ta32KyY0NJY2x4Sk9oR3M/view?usp=sharing

 

works fine.

[PC Plum]

Going for the treble...  I managed to reproduce the unpitched slide to 255 error

 

Here is the eof file

 

https://drive.google.com/file/d/0B2oZs0ta32KyUl96STFGa2dZaDA/view?usp=sharing

 

When you try to pull the resulting XML into the toolkit it tells you of an error at (3581, 291) and low and behold EoF is trying to author an unpitched slide to fret 255.  You can see in the EoF project that it looks like I authroed it correctly there.

 

 

 

Enough trouble shooting for one day...

 

 

Thanks again :D

 

 

 

 

 

Edit - after looking into it some more, I reckon the 255 error is caused by the same glitch that is causing the slides to go to the wrong fret.  My theory is that EoF is writing to XML using the thinest string as the slide beginning point, instead of the usual thickest string.  The 255 is therefore explained by EoF getting confused about trying to slide a fret 8 to a fret 8.

 

I loaded up the project using 1436 and saved.  It came out perfect

 

https://drive.google.com/file/d/0B2oZs0ta32KySmRpYWd3b2ExUEE/view?usp=sharing

 

Thanks in advance for fixing it, I know you will :D

 

 

 

 

Edit - I used 1409, my bad :(

[th1rtyf0ur]

I made this

 

https://drive.google.com/file/d/0B2oZs0ta32KyVGZtS2dfQWE1bnc/view?usp=sharing

 

and it comes in game like this

 

https://drive.google.com/file/d/0B2oZs0ta32KycW1QQk5xTDFVRkk/view?usp=sharing

 

and I was wondering why there is a chord tail?  Another resulting effect of this (in my game anyway) is that the G chord fingering (1, 3) stays on screen for the duration of the muted chords, even though the fingering is nowhere near the fhps

 

 

The tail is there because of the slide/sustain, otherwise you wouldn't be able to have the slide. The muted notes don't appear to have any fingerings set- try setting the fingerings on those & then it should automatically add fret hand positions.

[th1rtyf0ur]

May as well make it a double whammy...

 

I had some strange stuff last night making this but I put it down to a one off, but now I see there is a problem.  Last night I tried to pull this arrangement into the toolkit and the toolkit gave me an error.  When I checked out this error, EoF had written an unpitched slide to fret 255 even though in the EoF project it clearly said unpitched slide to 6 (from 8).  Unfortunately I've overwritten the files now, but I can show you this

 

https://drive.google.com/file/d/0B2oZs0ta32KyelRSS1pOWGlBVTA/view?usp=sharing

 

https://drive.google.com/file/d/0B2oZs0ta32KySk1NTHEyV2ZUeEk/view?usp=sharing

 

I can't see anything wrong with the EoF authoring, but in game it comes out wrong.  For the record, EoF won't let me make it a slide up to fret 5 (if EoF is now taking the starting point from the highest string and hence why it tries to go up to fret 9) so I definitely authored it correctly.

 

Slides go from the lowest fret position in the chord, not the lowest (thickest) string, so in the case of your ---553 chord, it's sliding from the 3 to 7, which puts it at ---997 instead of the --775 you want. If EOF won't let you set the slide to 5, then go into tech view & make it an "advanced slide" by setting the slide for each string. There's a very detailed tech notes tutorial here:

 

http://customsforge.com/topic/890-tech-notes-tutorial-authoring-complex-bends-and-more/

[Alex360]

Going for the treble...  I managed to reproduce the unpitched slide to 255 error

 

Here is the eof file

 

https://drive.google.com/file/d/0B2oZs0ta32KyUl96STFGa2dZaDA/view?usp=sharing

 

When you try to pull the resulting XML into the toolkit it tells you of an error at (3581, 291) and low and behold EoF is trying to author an unpitched slide to fret 255.  You can see in the EoF project that it looks like I authored it correctly there.

same logic for pitched slide i think its about uchar type of lowest fret it clips to 255 somehow, need to debug things at rs.c and figure that out, but I'm still confused by debugging with gdb :(

[PC Plum]

 

Slides go from the lowest fret position in the chord, not the lowest (thickest) string, so in the case of your ---553 chord, it's sliding from the 3 to 7, which puts it at ---997 instead of the --775 you want. If EOF won't let you set the slide to 5, then go into tech view & make it an "advanced slide" by setting the slide for each string. There's a very detailed tech notes tutorial here:

 

http://customsforge.com/topic/890-tech-notes-tutorial-authoring-complex-bends-and-more/

 

 

I don't think that is correct, can I draw your attention to

 

https://drive.google.com/file/d/0B2oZs0ta32KySmRpYWd3b2ExUEE/view?pli=1

 

which I authored in EoF exactly the same, but I used an older EoF to make the XML output.

 

 

There is a change in behavour in the new EoF (or maybe the last few I don't update too often) regarding chord slides.

[PC Plum]

 

The tail is there because of the slide/sustain, otherwise you wouldn't be able to have the slide.

 

Technically I meant the handshape tag.  There should be none after that G chord with unpitched slide.

 

Is EoF writing the handshape tag up to the next (muted) chord or is it something else?  I have made unpitched slide chords many times, and they never had a sustained handshape tag after them before.

 

 

As for the fingering graphics staying on screen, I think thats just a game bug.  Apparently it happens sometimes in official songs too.

[Alex360]

@PC Plum, what is your  last working build version is? just for the record