Latest EOF releases (9-26-2020)

raynebc · May 31, 2017

Should the toolkit also reject hyphens in phrase names for the sake of having consistent rules as EOF and DDC?

cozy1 · June 1, 2017

Trouble maker. The toolkit does not create or edit section/phrase names it only uses what it is given. In all seriousness, I will take a look.

raynebc · June 1, 2017

I thought it filtered unaccepted characters out of the XML just like EOF? Was the filtering more limited in scope?

cozy1 · June 1, 2017

Toolkit filtering/validation is currently limited to song info (Album, Title, Artist, DLC Key, etc) that is displayed and can be edited in the CDLC Creator GUI. I recently added validation to vocals but this validation is only done if the CDLC author chooses to use the toolkit vocal editing feature.

I've located a place in toolkit code where phrase names may be validated and will try to implement in a couple of days. Section names are already validated by the toolkit and this validation is more restrictive (per the code cited by iminoshi). I don't consider phrase naming validation a big issue because DDC renames phrase when DD is applied; and all CDLC must have DD to work correctly with Remastered. Still there are some who choose not to apply DD to their CDLC so there is a chance that non-compliant phrase names could slip through. This is very unlikely if EOF is checking when phrases are created/edited.

raynebc · June 1, 2017

So in addition to the other characters EOF is filtering out of phrase names ( ( } , \ : { " ) / ), should I just also filter out (or at least warn about) the presence of hyphens? Are any other characters expected to be problematic at this time (like underscores)?

Should the hyphen still be allowed in other scenarios such as lyrics?

cozy1 · June 5, 2017

Looking at the toolkit code for section naming you will not find any special characters or punctuation used in ODLC. For consistency it may be best to apply this validation to phrase naming as well (so no underscores, hyphens, etc).

raynebc · June 5, 2017

We should probably be specific about what is or isn't allowed. Would the developers go as far as saying that only alphanumeric characters should be allowed for phrases and sections?

Xyber · June 5, 2017

@@Xyber
Using the latest beta toolkit I am not able to reproduce the chord issues with the EOF project files that you posted. The CDLC compiles and plays through completely in game with no observed chord issues. I compiled both DropD and E Standard versions of the CDLC and both are synced and play extremely well ... good job. (The Low E string is almost never used in the song so there is no reason it can't be played in E Standard tuning which may save time loading in the game.)

Here's what I observed in reviewing your EOF project files:
1) The EOF project is missing Album Artwork so the toolkit will use default artwork.
2) PART REAL_GUITAR_22_RS2.xml uses non-compliant phrase names, e.g. "Outro-Guitar Solo", "Pre-Chorus". These should be "outro" and "prechorus". Appling DD to the arrangement with the toolkit will convert and replace these non-compliant phrase names. If you are not applying DD then this naming may be a possible source of problems. I always apply DD with the toolkit because Remastered now requires it to maintain song stats.

Let me know if the linked CDLC play through in-game for you.

Weird, I wonder what the issue was for me at first then. But it seemed to fix itself for me, so that's good at least. As for your observations, I had only quickly synced up the song, added phrases the the imported section names and imported the tab so there's still plenty to go through and fix. I always make a rough version first that I can play so it's easier to notice what needs to be fixed. :)

Haven't had time to work on the song since I last posted, but have some time off now and hope I can get it done properly in the coming days.

Thanks for looking into it though.

cozy1 · June 5, 2017

We should probably be specific about what is or isn't allowed. Would the developers go as far as saying that only alphanumeric characters should be allowed for phrases and sections?

@Chlipouni Is this what you have done in DDC with random/sequential phrase naming? Looks like DDC is using only alpha numeric for phrases when appling DD.

iminashi · June 5, 2017

I haven't come across ODLC that uses other than alphanumeric characters for phrase names. Usually they are short like "A", "B", "C", but there are also names like "solo2".

firekorn · June 5, 2017

Yeah ODLC uses simple phrase naming with only alphanumeric characters (and i understand why when you actually create DD as it's very easy to be confused if the name aren't clear) and DDC do the same thing.

albatross213 · June 5, 2017

Should the hyphen still be allowed in other scenarios such as lyrics?

I don't think I've seen anyone specifically answer this question yet, but hyphens definitely occur in the lyrics of some ODLC (e.g. in My Generation for the stuttering parts).

firekorn · June 5, 2017

Yeah the hyphen is definitely allowed in lyrics.

raynebc · June 6, 2017

Should we wait for @@Chlipouni to consider it a consensus on alphanumeric characters only for phrases/sections?

Chlipouni · June 6, 2017

I agree for alphanumeric limitation only for phrases and sections. Section names are limited on a predefined list and phrase names are never displayed in the game.
DDC keeps EOF section names and always overrides phrase names.
So it is ok for me ...

raynebc · June 6, 2017

Alright, I'll work on that sometime soon.

iminashi · June 8, 2017

32 seems to be the maximum number of bendvalues/bend tech notes you can have on a single note. 33 or more and the game will crash after tuning.

The limit can be bypassed by using linknext. I tried it by making an xml file that had a G string 7th fret note with 32 bendvalues linked to a G string 7th fret note with 32 bendvalues and the game didn't crash.

raynebc · June 24, 2017

Hi, folks. The latest hotfix (6-23-2017) is in the first post. Changes are as follows:

*Added logic to prevent an occasional failure to load eof.dat when changing display window sizes.

*Updated guitar tap and strum input modes to allow for a sixth fret button to be defined, for use in pro guitar and GHL mode tracks.

*Fixed a bug with guitar tap and guitar strum input modes where if keyboard keys were mapped to the fret/strum buttons, that input was allowed to also activate EOF's hardcoded keyboard shortcuts during playback.

*Changed RS exports so that non-alphanumeric characters are filtered out of RS phrase and RS section names, following DDC's behavior and reducing the risk of the phrase/section name causing problems in-game. If RS export(s) are enabled during save, EOF will warn if any sections/phrases will have such characters ommitted.

*Added the ability to author Guitar Hero Live style tracks, for use with Clone Hero. To use this style of authoring for one of the traditional 5 lane guitar/bass tracks, enable the "Enable GHL mode" function from the Track menu. When this mode is in effect, the 3 lowest lanes are used to author white notes, the 3 highest lanes are used to author black notes and the middle mouse button can be used to place open notes. In Rex Mundi input mode, the number 7 can also be used to author open notes. Alternatively, the "Note>Convert GHL open" function can be used to change selected notes into open notes if GHL mode is enabled for the active track. EOF will keep the chart as intact as it can when enabling/disabling GHL mode on a track that already has notes in it (or when copy/pasting notes between GHL and non-GHL tracks), but since GHL mode has six lanes IN ADDITION to an open note, lane 3 black notes are converted to 5 lane chords when a GHL track is converted to non-GHL format. This is so open notes can remain authored as open notes, but chords containing lane 3 black notes won't survive the conversion and EOF will warn about this and highlight affected notes. The 3D representation of GHL tracks three lanes, each of which can have one white gem and/or a black gem. If a lane has both gems, it is considered a "barre" chord (in that the player would hold two buttons down with one finger to play it) and EOF displays this as a black and white rectangle instead of a black or white triangle. The clipboard format has changed, make sure to perform another copy operation before performing a paste or the paste will malfunction.

iminashi · June 24, 2017

I came across an oblique bend where EOF isn't producing the expected result.

http://i.imgur.com/kw7vxoH.png

http://i.imgur.com/wuORNow.png

In the XML, the chordnotes have different values for sustain, but Rocksmith doesn't allow that and as a result the sustain of the chord is too long:

http://i.imgur.com/OOtwbsl.png

Manually setting the second double stop as 'split' doesn't improve the situation. It adds the 16th fret note to the XML, but also makes a duplicate of the 18th fret bend-down note. Removing the duplicate note, setting the 16th fret chordnote to have the correct sustain and adding linknext to the chordnotes gets the correct result.

XML made by EOF (without 'split'):

</bendValues>

</note>

</notes>

</bendValues>

</chordNote>

</chord>

</chords>

XML made by EOF (with 'split'):

</bendValues>

</note>

</bendValues>

</note>

</notes>

</bendValues>

</chordNote>

</chord>

</chords>

XML that produces the correct result:

</bendValues>

</note>

</notes>

</bendValues>

</chordNote>

</chord>

</chords>

And two unrelated points:

GP import only imports the transition (slide, bend, hammer) of a grace note when it is set as "before the beat". If it is "on the beat", the transitions are not imported at all. Also, the way the bend grace note is imported doesn't make sense.

Something I noticed as I was looking at how the ignore status is used in official content: In ODLC, when a chord is set as ignore, the individual chordnotes don't have the ignore status and EOF's RS import will import the chord without the ignore status.

raynebc · June 24, 2017

What version of EOF are you using? I only ask this because the XML isn't in abridged format, so it's either an old version or you manually disabled that export preference.

GP import only imports the transition (slide, bend, hammer) of a grace note when it is set as "before the beat". If it is "on the beat", the transitions are not imported at all.

It was intentionally programmed this way, but I don't remember if there was a reason for it. Does anybody know a reason why it shouldn't?

Also, the way the bend grace note is imported doesn't make sense.

In what way doesn't it make sense? EOF makes the grace note bend enough half steps to reach the pitch of the attached note.

Something I noticed as I was looking at how the ignore status is used in official content: In ODLC, when a chord is set as ignore, the individual chordnotes don't have the ignore status and EOF's RS import will import the chord without the ignore status.

Have you found if it makes any difference in-game whether the chordnotes have ignore status? Can you list some songs that are authored this way (in case anybody wants to verify this is the official way to author them)? Do any of the toolkit developers have concerns with me making this change?

iminashi · June 24, 2017

I'm on the latest hotfix. I had disabled the abridged XML because I wanted to see if it was the cause of some problem I was having, but it wasn't (was probably showlights or something). I realized that I should have turned it on after posting that. :unsure:

This is how a bend grace note imports for me:

http://i.imgur.com/0XUpCKR.png

Shouldn't the notes be linked and the second note have a bend tech note on top of it?

EDIT: And the notes should be on the same fret (4 in this case)

I don't think having the ignore status on chordnotes has any effect, considering how the detection of chords works (the complete chord is either a hit or miss, you can't get a miss on a single note inside a chord).

A quick test:

chord ignore=1, all chordnotes ignore=0, game ignores it

chord ignore=0, all chordnotes ignore=1, game counts as miss

"All I Wanna Do" and "Don't Look Back in Anger", for example have lots of chords with the ignore status. "Cherub Rock" and "25 or 6 to 4" (rhythm) also have lots of them. I'm not seeing any chordnotes with ignore=1.

raynebc · June 25, 2017

About the grace notes I think it might be a matter of personal preference unless there is a definitive source that indicates how such tablature is supposed to be interpreted.

firekorn · June 25, 2017

Well the export from gpx to gp5 off grace note being a bit fucked up (add whammy bar and don't put the bend at the proper place) it makes it a bit complicated to do something nice to show what is and what should be with actual file available so only screenshot for now.

GP file :

http://i.imgur.com/u15oqWQ.png

EOF expected result :

http://i.imgur.com/JOmJW7A.png

If anyone wants to show me some case of grace note they encountered, i'll be glad to indicate how i would always expect them to import.

raynebc · June 25, 2017

It's hard to see whether most people would want to interpret a ghost transition grace note as a pre-bend (uses linknext status) or an extra note to be played.

firekorn · June 25, 2017

@@raynebc even if the grace note isn't linked to the next note, it's very doubtful the next note would be on a different fret regarding bend grace note. If anyone as actual tab using it, i'm not against presenting how i would expect it to show up in EOF but doing all cases where a grace note can be use and their equivalent in EOF would be a bit tedious especially considering that GPx to GP5 grace note with bend get fucked up pretty heavily which makes me think grace note should be avoided anyway.

Sign In

Latest EOF releases (9-26-2020)

Recommended Posts

Link to comment

Share on other sites

Top Posters In This Topic

Popular Days

Top Posters In This Topic

Popular Days

Popular Posts

raynebc

raynebc

raynebc

Posted Images

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Join the conversation

Recently Browsing 0 members

Important Information