Jump to content

Latest EOF releases (9-26-2020)


raynebc

Recommended Posts

Hi, folks. The latest hotfix (9-28-2018) is in the first post. Changes are as follows:

*Updated copy/paste, clone to/from and auto adjust logic to preserve disjointed status.

*Updated the save logic to not warn about gems in the same disjointed chord being too close together to enforce the minimum note distance.

*Added a "Save separate Guitar Hero files" export preference that will specify whether ghwt_drum.array.txt, notes_gh3.mid and note_ghwt.mid are created when the project is saved.

*Corrected an issue where the new MIDI import logic (for handling disjointed chords) could cause some notes to incorrectly detected as auto HOPO notes until fixup logic redetects that they are not auto HOPOs.

*Updated MIDI import to treat "PART GUITAR COOP GHL" and "PART RHYTHM GHL" as GHL tracks.

*Updated MIDI import to read the GHL track difficulty tags ("diff_bassghl" and "diff_guitarghl").

*Updated MIDI export to write the GHL track difficulty tags even when PART RHYTHM or PART GUITAR COOP are renamed to define the GHL guitar or bass track.

*Added a message that is displayed at the end of MIDI/Feedback import if the "Imports drop mid beat tempos" preference is enabled and leads to any beats being removed during the import, which could affect the grid snapness of notes.

*Changed RS2 export to automatically add ignore status to any gem that uses a fret number higher than 22, to ensure the game correctly handles this note, which it would otherwise not score but would count against the player's mastery percentage for the song.

*Changed the border color for selected lyrics' note rectangles to red instead of white to make them more visible.

*Fixed a bug with the recent Feedback import logic (to process toggle HOPO and slider markers at the end of each track difficulty's import) that could cause notes/chords with W3 to be deleted from charts with multiple difficulties.

*Updated RS2 export to only write the first 32 bend points for each note/chordnote, since having more of them would cause the game to crash. The warning given during save was updated to reflect that this action is taken.

*Added options to the "Track>Rocksmith>Arrangement type" menu to specify whether the arrangement is the normal one (whose play stats are the one listed in learn a song and other places), a bonus arrangement or an alternate arrangement, for use in Rocksmith 2014. RS1 export will write any track that is marked as a bonus or alternate arrangement as an alternate arrangement since RS1 doesn't support bonus arrangements.

*Added a "Track>Rocksmith>Picked bass" function that will specify that exported bass arrangements for RS1 and RS2 are picked bass instead of fingered bass.

  • Like 5
Link to comment
Share on other sites

  • Developer

@@raynebc So in new version of EOF I see Song>Track>PART_REAL_GUITAR_BONUS and I see new Track>Rocksmith>Arrangement type> BOnus and Alternate. 

I am a little confused.  What is the purpose of PART_REAL_GUITAR_BONUS if any track seems like it can be specified as BOnus or Alternate using Track>Rocksmith>Arrangement type>?   Seems like PART_REAL_GUITAR_BONUS is not needed.

Would it be possible to have EOF set the arrangement element values as follows according to how the new Track>Rocksmith>Arrangement type> BOnus and Alternate are used?

 

Default : Represent = 1, Bonus = 0

Alternate : Represent = 0, Bonus = 0

Bonus : Represent = 0, Bonus = 1

 

Toolkit can handle the rest.
Thanks

 

EDIT: after second attempt the new EOF version actual seems to be working the way I had asked for/described above.  I am still unclear as to the use of PART_REAL_GUITAR_BONUS firekorn explained the useage to me in PM.   Now time for me to tweak the toolkit to accommodate the changes.

Thanks for all you do.  No repsonse needed.


 

  • Like 1

Are you tired of AV False Positives???  Now accepting donations on my website (Click Here)  Your donation will be used towards buying a code signing certificate.   CGT is now compatible and safe to use with Rocksmith® 2014 Remastered ... 

 

Latest Build of Custom Game Toolkit (CGT) w/ Game Save Gigbox       Latest Build of Rocksmith Toolkit       Latest Build of Customs Forge Song Manager (CFSM)

 

All bug reports and help requests please include your: OS, CPU, AV, .NET Framework versions along with a description of the issue (include screenshots of error if possible).  It should go without having to say ... make sure you are using the latest build before submitting bug reports or asking for help.

 

*  Remember to use your magic words (please and thank you) if you would like a response.  Don't use phrases like 'thanks anyhow' as it is demeaning.

Link to comment
Share on other sites

  • Developer

I hadn't decided yet whether the bonus track should be marked as a bonus arrangement by default, but I suppose that makes sense. Should I make that so?

Maybe it should NOT be named PART_REAL_GUITAR_BONUS since Track>Rocksmith>Arrangement type> BOnus is not selected by default for this arrangement.  This was the cause of the trouble I ran into above until I figured it out.

 

If the purpose is to provide support for maximum of 5 RS arrangements as firkorn described to me, then  maybe a more generic arrangement name, such as, PART_REAL_GUITAR_OTHER would be appropriate.   Then leave selecting Track>Rocksmith>Arrangement type> BOnus or Alternate to the user.

 

@@firekorn What do you think?

Are you tired of AV False Positives???  Now accepting donations on my website (Click Here)  Your donation will be used towards buying a code signing certificate.   CGT is now compatible and safe to use with Rocksmith® 2014 Remastered ... 

 

Latest Build of Custom Game Toolkit (CGT) w/ Game Save Gigbox       Latest Build of Rocksmith Toolkit       Latest Build of Customs Forge Song Manager (CFSM)

 

All bug reports and help requests please include your: OS, CPU, AV, .NET Framework versions along with a description of the issue (include screenshots of error if possible).  It should go without having to say ... make sure you are using the latest build before submitting bug reports or asking for help.

 

*  Remember to use your magic words (please and thank you) if you would like a response.  Don't use phrases like 'thanks anyhow' as it is demeaning.

Link to comment
Share on other sites

Changing the track's name now, after almost two years, could be troublesome (confusing to users, complicating MIDI import, etc). I can't see why it should be restricted by its name though, EOF allows bass tracks to be authored in PART REAL GUITAR, and guitar tracks in PART REAL BASS. It's useful for authors to have the flexibility.

Link to comment
Share on other sites

Would it be radical to implement an add/remove track function for EOF instead of the current system? Then you could have e.g. PART_REAL_GUITAR_2, 3, etc. and maybe even make the names user-definable, with the current track names as defaults. Just a sudden thought.

 

What I really came here to say was that using red to select lyrics makes it hard this time to see selected lyrics outside the piano roll range. I'm thinking bring back white and make the lyrics blue instead.

Link to comment
Share on other sites

  • Administrator

@@raynebc @@cozy1

 

I had a long discussion with Cozy cause the recent changed regarding the handling of the represent and bonus argument in the xml weren't followed by the toolkit making the additionnal option in the arrangement type in EOF more problematic regarding the current way the toolkit handled those argument.

 

The general conclusion was that the toolkit should just trust EOF xml output regarding the arrangement properties but that means that EOF should make sure that those information have at least some kind of common sense to avoid some possibly problematic situation.

 

The rule i can think of at the moment are the following :

One representative track per path (lead/rhythm/bass)
Only one representative track per path (other track should be set either as alternative or bonus)

 

I have no idea how RS will handle a CDLC with multiple representative track (no idea which one will be choosen as the actual default or what name will de displayed).

If there's no representative track, the result is that RS will display a cross instead of your mastery % on the song list (making that path harder to access via Score Attack too) and you'll be sent to either the alt/bonus track for the path you are on or to another available path.

 

This also cause me some concern regarding the fact the path for the guitar track are set to "undefined" by default in EOF which makes all of this even harder to handle.

 

Regarding track naming in EOF, it doesn't matter to me and it never mattered as far as i'm concern. Track name can be altered by the charter with the rename option in the track menu anyway. I wouldn't trust track name in any kind of way to reflect what they are about.

Firekorn's workshop
In Flames Discography

#FirekornHasDoneNothingForTheCommunity

Link to comment
Share on other sites

Would it be radical to implement an add/remove track function for EOF instead of the current system?

This kind of thing was planned at one point, but it would be a lot of work. It would also not be very useful now that one EOF project can have the maximum number of arrangements that can be present for a song. I'm not aware of any rhythm games that support custom tracks like this, they generally all have to use pre-defined names.

 

What I really came here to say was that using red to select lyrics makes it hard this time to see selected lyrics outside the piano roll range. I'm thinking bring back white and make the lyrics blue instead.

I see what you mean about it not contrasting in that scenario, but what about making the highlight color blue? It appears to make all selected lyrics stand out regardless of whether they're in piano roll scope, out of scope or pitchless.

 

@@firekorn

I'm not opposed to making each guitar track a particular path by default (ie. PART REAL_GUITAR default to being the lead arrangement), but we'd probably want to get some input from the authors in general. By default, both real bass tracks are set as the "normal" representative bass arrangement. I can make it so that "PART REAL_GUITAR_22", "PART REAL_BASS_22" are alternate arrangements by default and that "PART REAL_GUITAR_BONUS" is a bonus arrangement by default if you think that will help. Otherwise the quickest fix I can do is for the save function to only allow one arrangement of each path to export as representative and forcibly change others to "alternate" if necessary. I'd want to display a warning for this during normal save, as well as warnings if the representative arrangement for a path is not authored. Let me know what you think about these changes.

Link to comment
Share on other sites

  • Administrator

The default that the toolkit used until now is the following :

PART REAL_GUITAR = Rhythm default

PART REAL_GUITAR_22 = Lead default

 

No idea how was the BONUS part treated. but it seems fair to give it a status of bonus arrangement by default (lead or rhythm) according to the default name.

 

So far the toolkit is taking care of putting only one representative track per path. But in doing so, it overwrite the represent tag. If EOF end up doing that check this would allow for the newly added option of EOF to actually be used as intended because the toolkit won't alter that argument anymore.

Firekorn's workshop
In Flames Discography

#FirekornHasDoneNothingForTheCommunity

Link to comment
Share on other sites

@@raynebc Blue highlight sounds good.

 

I might have just said something about the tracks since the track menu feels cluttered/disordered. Since changing default track names is out of the question (they're just based on RB3, right?), it might help if at least similar tracks were listed together, as in the REAL_GUITAR and REAL_BASS parts are in order (PART DANCE really looks out of place in there), if compatibility won't be an issue. Maybe Ctrl+Tab could just cycle through non-empty tracks as well.

 
edit: I completely forgot that you can rename tracks. I guess if only changing the track type is possible (e.g. fake guitar, real guitar, drums, vocals) there could be room for whatever tracks one might need (RB3 vocal harmonies, anyone?).
Link to comment
Share on other sites

@@firekorn I think it's appropriate to make default arrangement paths/types match what the toolkit had been assuming. I also think it's sensible to make the tracks with the highest default fret limit the lead guitar arrangement or representative bass arrangement. Please let me know if you agree with these EOF changes:

->Make PART REAL_GUITAR_BONUS rhythm path, bonus arrangement by default

->Make PART REAL_GUITAR rhythm path, normal arrangement type by default

->Make PART REAL_GUITAR_22 lead path, normal arrangement type by default

->Make PART REAL_BASS bass path, alternate arrangement type by default

->Make PART REAL_BASS_22 bass path, normal arrangement type by default

 

And also with the added warning and arrangement override during save if the user has either no representative or multiple representative arrangements for a path (lead/rhythm/bass) that is present in the project.

 

@@dan_A Changing the order of tracks in Song>Track would be messy because at this time it's based off the track ordering internally to EOF and that cannot change. I can make a user preference for CTRL+Tab and CTRL+SHIFT+Tab to skip empty tracks if you would find that helpful, let me know. There are CTRL+SHIFT+Up/Dn shortcuts to cycle to the next/previous track of the same type (ie. pro guitar), but it doesn't take into account whether the track is empty.

Link to comment
Share on other sites

->Make PART REAL_GUITAR_BONUS rhythm path, bonus arrangement by default

->Make PART REAL_GUITAR rhythm path, normal arrangement type by default

->Make PART REAL_GUITAR_22 lead path, normal arrangement type by default

->Make PART REAL_BASS bass path, alternate arrangement type by default

->Make PART REAL_BASS_22 bass path, normal arrangement type by default

 

That's completely opposite of how I using them. Can you just make this a global eof setting rather than per project setting. So if in my last project I set PART REAL_GUITAR as lead path, bonus arrangement it would be set so as default for all new projects.

Link to comment
Share on other sites

It shouldn't be too hard to make it automatically remember the last arrangement path and type the user defined for a track. Doing it this way would be less of a hassle than having to design a dialog with drop downs, etc.

 

An alternative (which I think I would consider the best option) would be to add a "Set as default" menu function so you can set your preferred arrangement settings once per track and not worry about one-off instances (ie. working on a song with 5 guitar arrangements and no bass arrangements) changing your preferences. Let me know what you think.

Link to comment
Share on other sites

  • Administrator

@@theSG Note that regarding the guitar track, it also the opposite of how i work but i was always altering the arrangement type anyway so i don't loose time regarding that change and i prefered to state what the toolkit considered as "default" than what i used in my own corner.

 

If each user can define their own default option, it's even better.

 

@@raynebc One interesting fact that was brought up to me regarding this is that official DLC haven't used the "bonus" naming since RS2014 release (only on disc song and RS1 songs are using it) so making the Bonus guitar track as an alternate track seems more appropriate by default. Note that this is a minor nitpick and that i don't really care that much about it as it won't change much of anything for user. Just more of a FYI than anything.

Firekorn's workshop
In Flames Discography

#FirekornHasDoneNothingForTheCommunity

Link to comment
Share on other sites

  • 2 weeks later...

Hi all!

 

I'm not sure if this is the right place to ask, but I'd like to make a feature request for EOF.

 

Current behavior: When you click on a note and hit N to change the fret number, you have to click in the box to change the fret number, and your mouse pointer has to continue to hover over the text box, otherwise, the cursor disappears and keyboard input does nothing

 

Expected behavior: Once you click into the text box, the cursor should stay there, regardless of mouse position.

 

The problem for me is the way I chart by hand/by ear, I usually have guitar in my lap and a keyboard and mouse on the couch next to me. So with my left hand, I click in the box, and then reach over to the keyboard, and by the time I get there, the mouse has moved slightly and I can't type, and have to go back and mouse over the box again and try to type a 2nd time. It's just super fiddly is all.

 

What I would love to see: When selecting a single note and hitting N (or hitting Next), it would be nice if the cursor was already in the text box, behind the number, ready for backspacing (or in front, for deleting, lol).

 

This may sound stupid, but when I chart by ear, I sync a blank "click track" GP tab to the song in GPA, then I import it into EOF to get the sync. Then, I just go through the track first putting open notes for every note/chord I hear in the song, and then I go back and fill the notes in one at a time, using N or Next, as I check them on the guitar. Then I just copy and paste the repeating parts (I have overwrite on) correcting variations when needed. It's less daunting to me to do it in stages, and I can recheck my note positioning with a fresh perspective as I'm adding the fret numbers in.

 

Does that make sense? Anyway, it would be greatly appreciated and make my hand charting soooo much faster.

 

I have a Tom Waits song that I'm dying to do, but the whole thing is noodling, and I'm dreading the frustration of trying to plug all those notes in, while trying to decipher the notes by ear as I go. the way it's handled currently.

 

Sorry for writing a novel, and thanks! :D

 

  • Like 1

Words of wisdom for CDLC charters:

 

"When in doubt, steal a tone from Kansas' Carry On Wayward Son"

 

- Billkwando

 

Download my L'Arc~en~Ciel Ken "Love Driver Cat" custom Inlays here

Link to comment
Share on other sites

For single note, it would be faster to adjust the fret number with CTRL+1 to 0 for 1 to 10 and CTRL+F1 to F12 for 11 to 22.

 

Not with my left hand, it's not. ;)

 

That's why I wrote the long post, and edited it about 10 times, to make it perfectly clear what I was doing and why I was asking. :P

 

I still think it's a reasonable request, and that the current program behavior is not typical of most programs, or any that I'm aware of. If I click in the search bar at the top of my browser, and then go down and mouse over my clock, the cursor is still flashing in the search bar.

 

Also, that method removes the Next button from the equation, and clicking on each note individually would be a nightmare for keeping track of where I am, because on my screen(s) which are feet away from me, it's very hard to read the note number on the chart.......and the same shortcut that turns on my screen magnifier zooms the chart, so I have to click out of EOF if I want to use it (and even worse, the shortcut that closes the magnifier also tries to close EOF). I have 2 mouse buttons dedicated to the magnifier, 1 to open and 1 to close, in case you're wondering how I hit those shortcuts with one hand.

 

Believe me, I wouldn't be asking if I knew of a better/easier way. I've been at this for nearly 5 years now, and the text input thing has always bothered me, but I just dealt with it because I didn't want to trouble anyone.....but I'm just starting to realize just how much it has been hampering my productivity.  It bugs me even when I am using 2 hands. I'm sure it bugs other folks as well, but like I did, they likely just get used to it and just think of it as the price of doing business, so to speak.

Words of wisdom for CDLC charters:

 

"When in doubt, steal a tone from Kansas' Carry On Wayward Son"

 

- Billkwando

 

Download my L'Arc~en~Ciel Ken "Love Driver Cat" custom Inlays here

Link to comment
Share on other sites

If you enable the "Click to change dialog focus" preference, you don't have to worry about the mouse movement taking focus away from the fret number field you're editing. Or at least that's how it's meant to work. I'm seeing that dialog controls that aren't text input fields can still steal focus when moused over, so I have some work to do to improve that.

 

Using the "Edit note frets/fingering" function (pressing F instead of N) may be more helpful in your case since the controls that can steal focus are further away from the fret number field. I could also see how hard it would be to automatically have this function give focus to the fret number field of whichever string was just toggled on.

  • Like 1
Link to comment
Share on other sites

If you enable the "Click to change dialog focus" preference, you don't have to worry about the mouse movement taking focus away from the fret number field you're editing. Or at least that's how it's meant to work. I'm seeing that dialog controls that aren't text input fields can still steal focus when moused over, so I have some work to do to improve that.

 

Using the "Edit note frets/fingering" function (pressing F instead of N) may be more helpful in your case since the controls that can steal focus are further away from the fret number field. I could also see how hard it would be to automatically have this function give focus to the fret number field of whichever string was just toggled on.

 

Thanks for the tip, but it appears I already had that option checked, alas.

 

The reason I don't use F is because, again, there is no button to advance to the next note, and because I lose all the other options I need while placing a note (vibrato, string mute, ignore, link next, etc). shift V I can do 1-handed, but you get the idea.

 

Edit: Would be nice if the cursor popped in for the other boxes too, like Set End Fret, Unpitched Slide, bend, etc. One less extra step. ;)

Words of wisdom for CDLC charters:

 

"When in doubt, steal a tone from Kansas' Carry On Wayward Son"

 

- Billkwando

 

Download my L'Arc~en~Ciel Ken "Love Driver Cat" custom Inlays here

Link to comment
Share on other sites

I'll work on expanding the scope of the "Click to change dialog focus". The other functions you mention automatically set the cursor focus in the input fields.

 

I'll see about setting the default cursor focus to the last-placed gem (if applicable) when pulling up the edit pro guitar note dialog.

  • Like 1
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...
×
×
  • Create New...

Important Information

By using this site, you agree to our Guidelines. We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. - Privacy Policy